Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test(node_compat): enable more stream-writable tests #24328

Merged
merged 2 commits into from
Jun 25, 2024
Merged

test(node_compat): enable more stream-writable tests #24328

merged 2 commits into from
Jun 25, 2024

Conversation

satyarohith
Copy link
Member

Towards #24232

@satyarohith satyarohith enabled auto-merge (squash) June 25, 2024 07:18
littledivy
littledivy approved these changes Jun 25, 2024
View reviewed changes
Copy link
Member

@littledivy littledivy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@satyarohith satyarohith reopened this Jun 25, 2024
@satyarohith satyarohith enabled auto-merge (squash) June 25, 2024 09:05
@satyarohith satyarohith merged commit b71a859 into denoland:main Jun 25, 2024
33 checks passed
@satyarohith satyarohith deleted the enable_writable_node_tests branch June 25, 2024 10:20
sbmsr pushed a commit to sbmsr/deno-1 that referenced this pull request Jul 2, 2024
@satyarohith @sbmsr
test(node_compat): enable more stream-writable tests (denoland#24328)
0f7d617
@sbmsr sbmsr mentioned this pull request Jul 2, 2024
Closed
zebreus pushed a commit to zebreus/deno that referenced this pull request Jul 8, 2024
@satyarohith @zebreus
test(node_compat): enable more stream-writable tests (denoland#24328)
7737755
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@littledivy littledivy littledivy approved these changes

@kt3k kt3k Awaiting requested review from kt3k

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@satyarohith @littledivy